Fix TypeDecl code to include abstract/final and generics #5726 #5728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltek
reviewed
Jan 5, 2026
Contributor
maltek
left a comment
maltek
left a comment
There was a problem hiding this comment.
Thank you!
I think it would be better to loop over all modifiers of the type, instead of listing them here one by one. Otherwise we will always be missing some of them. I.e. do something like typ.getModifiers.asScala.map(_.asString).mkString("", " ", " ") (I haven't tested that snippet though.)
maltek
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include abstract/final modifiers and generic parameters in TypeDecl.code for Java; add a regression test. Fixes incorrect rendering described in #5726.