[pysrc2cpg] Enrich Python import nodes with location metadata and exact code in the code property (#5651) #5730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he code property + add tests (joernio#5651)
ventusfortis
changed the title
maltek
reviewed
Jan 5, 2026
...i/frontends/x2cpg/src/main/scala/io/joern/x2cpg/frontendspecific/pysrc2cpg/ImportsPass.scala
Outdated
Show resolved
Hide resolved
...i/frontends/x2cpg/src/main/scala/io/joern/x2cpg/frontendspecific/pysrc2cpg/ImportsPass.scala
Outdated
Show resolved
Hide resolved
…t/dataflow expectations for exact code strings
maltek
reviewed
Jan 15, 2026
Contributor
maltek
left a comment
maltek
left a comment
There was a problem hiding this comment.
Looks good! We're almost there.
To get past the code style checker, run sbt scalafmtAll and commit the changed code.
joern-cli/frontends/x2cpg/src/main/scala/io/joern/x2cpg/passes/frontend/XImportsPass.scala
Outdated
Show resolved
Hide resolved
maltek
approved these changes
Jan 16, 2026
Contributor
Author
|
Test are failing, but the failed tests don't seem to be affected by changes in my commits =/ Correct me if I'm wrong |
Contributor
|
the failing tests are Given that this PR touches the representation of imports in Python, it seems likely to me that your change is responsible. Unfortunately, I'm not familiar with how the python type recovery works either. I suspect there is some code there that's looking at the code field that you've changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a runOnPart method for python imports, which enriches import nodes with missing data about location (#5651 and also fixes the code property to be exact in output