Skip to content

Replace .orNull call #5761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
max-leuthaeuser wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace .orNull call #5761

max-leuthaeuser wants to merge 2 commits into from

Conversation

@max-leuthaeuser
Copy link
Contributor

@max-leuthaeuser max-leuthaeuser commented Jan 16, 2026

No description provided.

maltek
maltek requested changes Jan 16, 2026
View reviewed changes
Copy link
Contributor

@maltek maltek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's fix .method to return an Option[] instead of crashing when there is no method

@max-leuthaeuser
Copy link
Contributor Author

max-leuthaeuser commented Jan 16, 2026 •
edited
Loading

That only shifts the issue to CfgNodeMethods.method (or higher up the call chain). All these methods are not null-safe.
Also: having no parent method always indicates a frontend issue so crashing early is good.

@ml86
[semanticcpg] Remove special handling for invalid CPG format.
1318ffb 
No more special handling to account for invalid CPG format when
expanding from CFG nodes to METHOD node.
The frontends should by now be fixed, lets see what our integration
tests say.
@ml86
Copy link
Contributor

ml86 commented Jan 19, 2026

As discussed on Zoom, we can remove this special handling this the frontends have already been fixed.

@ml86 ml86 requested a review from maltek January 19, 2026 08:57
@maltek
Copy link
Contributor

maltek commented Jan 19, 2026

we have to finish review and merge #5701 before this one

@ml86
Copy link
Contributor

ml86 commented Jan 19, 2026

I thought that is already in and released...

@maltek maltek mentioned this pull request Jan 19, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ml86 ml86 ml86 approved these changes

@maltek maltek Awaiting requested review from maltek

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@max-leuthaeuser @ml86 @maltek