Skip to content

Deprecate delete onExitTest in test fixtures #5764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ml86 merged 4 commits into from
Jan 19, 2026
+5 −28
Merged

Deprecate delete onExitTest in test fixtures #5764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
02de454
Deprecate delete on exit c2cpg
SuperUserDone Jan 16, 2026
8499b50
Deprecate deleteOnExit in Test Fixtures
SuperUserDone Jan 19, 2026
db8125e
Removed unused variable in CSharpCode2CpgFixture
SuperUserDone Jan 19, 2026
765cde5
Format
SuperUserDone Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions joern-cli/frontends/c2cpg/src/test/scala/io/joern/c2cpg/testfixtures/AstC2CpgFrontend.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,11 @@ trait AstC2CpgFrontend extends LanguageFrontend {
override type ConfigType = Config

def execute(sourceCodePath: java.io.File): Cpg = {
val cpgOutFile = FileUtil.newTemporaryFile(suffix = "cpg.bin")
FileUtil.deleteOnExit(cpgOutFile)
val cpg = newEmptyCpg(Option(cpgOutFile.toString))
val cpg = newEmptyCpg()
val pathAsString = sourceCodePath.getAbsolutePath
val config = getConfig()
.fold(Config())(_.asInstanceOf[Config])
.withInputPath(pathAsString)
.withOutputPath(pathAsString)
.withSchemaValidation(ValidationMode.Enabled)
val global = new CGlobal()

Expand Down
3 changes: 0 additions & 3 deletions joern-cli/frontends/c2cpg/src/test/scala/io/joern/c2cpg/testfixtures/C2CpgFrontend.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,10 @@ trait C2CpgFrontend extends LanguageFrontend {
override type ConfigType = Config

def execute(sourceCodePath: java.io.File): Cpg = {
val cpgOutFile = FileUtil.newTemporaryFile(suffix = "cpg.bin")
FileUtil.deleteOnExit(cpgOutFile)
val c2cpg = new C2Cpg()
val config = getConfig()
.fold(Config())(_.asInstanceOf[Config])
.withInputPath(sourceCodePath.getAbsolutePath)
.withOutputPath(cpgOutFile.toString)
val res = c2cpg.createCpg(config).get
new PostFrontendValidator(res, false).run()
res
Expand Down
4 changes: 1 addition & 3 deletions ...arpsrc2cpg/src/test/scala/io/joern/csharpsrc2cpg/testfixtures/CSharpCode2CpgFixture.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,7 @@ trait CSharpFrontend extends LanguageFrontend {
.getOrElse(Config().withSchemaValidation(ValidationMode.Enabled))

override def execute(sourceCodeFile: File): Cpg = {
val cpgOutFile = FileUtil.newTemporaryFile(suffix = "cpg.bin")
FileUtil.deleteOnExit(cpgOutFile)
val config = defaultConfig.withInputPath(sourceCodeFile.getAbsolutePath).withOutputPath(cpgOutFile.toString)
val config = defaultConfig.withInputPath(sourceCodeFile.getAbsolutePath)
val tmp = new CSharpSrc2Cpg().createCpg(config).get
new PostFrontendValidator(tmp, false).createAndApply()
tmp
Expand Down
3 changes: 0 additions & 3 deletions ...li/frontends/gosrc2cpg/src/test/scala/io/joern/go2cpg/testfixtures/GoCodeToCpgSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,11 @@ class DefaultTestCpgWithGo(val fileSuffix: String) extends DefaultTestCpg with S
}

def execute(sourceCodePath: java.io.File): Cpg = {
val cpgOutFile = FileUtil.newTemporaryFile("go2cpg.bin")
FileUtil.deleteOnExit(cpgOutFile)
goSrc2Cpg = Some(new GoSrc2Cpg(this.goGlobal))
val config = getConfig()
.collectFirst { case x: Config => x }
.getOrElse(Config())
.withInputPath(sourceCodePath.getAbsolutePath)
.withOutputPath(cpgOutFile.toString)
val res = goSrc2Cpg.get.createCpg(config).get
new PostFrontendValidator(res, false).run()
res
Expand Down
5 changes: 1 addition & 4 deletions ...tends/jssrc2cpg/src/test/scala/io/joern/jssrc2cpg/testfixtures/AstJsSrc2CpgFrontend.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,11 @@ trait AstJsSrc2CpgFrontend extends LanguageFrontend {
override type ConfigType = Config

def execute(sourceCodePath: java.io.File): Cpg = {
val cpgOutFile = FileUtil.newTemporaryFile(suffix = "cpg.bin")
FileUtil.deleteOnExit(cpgOutFile)
val cpg = newEmptyCpg(Option(cpgOutFile.toString))
val cpg = newEmptyCpg()
val pathAsString = sourceCodePath.getAbsolutePath
val config = getConfig()
.fold(Config())(_.asInstanceOf[Config])
.withInputPath(pathAsString)
.withOutputPath(pathAsString)
val hash = HashUtil.sha256(pathAsString)

new JavaScriptMetaDataPass(cpg, hash, pathAsString).createAndApply()
Expand Down
2 changes: 0 additions & 2 deletions ...rontends/pysrc2cpg/src/test/scala/io/joern/pysrc2cpg/testfixtures/Py2CpgTestContext.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,8 @@ class Py2CpgTestContext {

def buildCpg: Cpg = {
val cpgOutFile = FileUtil.newTemporaryFile(suffix = "cpg.bin")
FileUtil.deleteOnExit(cpgOutFile)
val config = Py2CpgOnFileSystemConfig()
.withInputPath(absTestFilePath)
.withOutputPath(cpgOutFile.toString)
.withSchemaValidation(ValidationMode.Enabled)
.withDisableFileContent(!enableFileContent)
if (buildResult.isEmpty) {
Expand Down
5 changes: 1 addition & 4 deletions ...ftsrc2cpg/src/test/scala/io/joern/swiftsrc2cpg/testfixtures/AstSwiftSrc2CpgFrontend.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,10 @@ trait AstSwiftSrc2CpgFrontend extends LanguageFrontend {
final override type ConfigType = Config

def execute(sourceCodePath: java.io.File): Cpg = {
val cpgOutFile = FileUtil.newTemporaryFile(suffix = "cpg.bin")
FileUtil.deleteOnExit(cpgOutFile)
val cpg = newEmptyCpg(Option(cpgOutFile.toString))
val cpg = newEmptyCpg()
val pathAsString = sourceCodePath.getAbsolutePath
var config = Config()
.withInputPath(pathAsString)
.withOutputPath(cpgOutFile.toString)
getConfig().foreach(c => config = config.withDefines(c.defines))
val astGenResult = new AstGenRunner(config).execute(Paths.get(pathAsString))
val astCreationPass = new AstCreationPass(cpg, astGenResult, config)(ValidationMode.Enabled)
Expand Down
4 changes: 0 additions & 4 deletions ...2cpg/src/test/scala/io/joern/swiftsrc2cpg/testfixtures/SwiftCompilerSrc2CpgFrontend.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,9 @@ trait SwiftCompilerSrc2CpgFrontend extends LanguageFrontend {
final override type ConfigType = Config

def execute(sourceCodePath: java.io.File): Cpg = {
val cpgOutFile = FileUtil.newTemporaryFile(suffix = "cpg.bin")
FileUtil.deleteOnExit(cpgOutFile)

val pathAsString = sourceCodePath.toPath.resolve("SwiftTest").toAbsolutePath.toString
var config = Config()
.withInputPath(pathAsString)
.withOutputPath(cpgOutFile.toString)
getConfig().foreach(c => config = config.withDefines(c.defines).withSwiftBuild(c.swiftBuild))

val cpg = new SwiftSrc2Cpg().createCpg(config).get
Expand Down
2 changes: 1 addition & 1 deletion joern-cli/frontends/x2cpg/src/main/scala/io/joern/x2cpg/X2Cpg.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import scala.util.matching.Regex
import scala.util.{Failure, Success, Try}

object X2CpgConfig {
def defaultOutputPath: String = "cpg.bin"
def defaultOutputPath: String = ""

final case class GenericConfig(
inputPath: String = "",
Expand Down
Loading