[c2cpg] Make NamespaceBlock fullNames unique #5767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- prepended filename - appended suffix with incrementing counter (file-local) - removed special handling for duplicated NamespaceBlocks in FullNameUniquenessPass Fixes: ShiftLeftSecurity/codescience#8593
…s namespaces. Renamed namespace suffix to `<extension>` as this is what they actually represent.
ml86
requested changes
Jan 21, 2026
joern-cli/frontends/c2cpg/src/test/scala/io/joern/c2cpg/passes/types/NamespaceTypeTests.scala
Show resolved
Hide resolved
joern-cli/frontends/c2cpg/src/test/scala/io/joern/c2cpg/passes/types/NamespaceTypeTests.scala
Show resolved
Hide resolved
joern-cli/frontends/c2cpg/src/test/scala/io/joern/c2cpg/cpp/features17/Cpp17FeaturesTests.scala
Outdated
Show resolved
Hide resolved
ml86
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<extension>with incrementing counter (file-local) (<extension>because this is what they actually represent in C++)Fixes: https://github.com/ShiftLeftSecurity/codescience/issues/8593