[kotlin2cpg] Fix LHS of array access not treated as an expression #5776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml86
requested changes
Jan 22, 2026
| val typeFullName = registerType(exprTypeFullName(expression).getOrElse(TypeConstants.Any)) | ||
| val identifier = identifierNode(arrayExpr, arrayExpr.getText, arrayExpr.getText, typeFullName) | ||
| val identifierAst = astWithRefEdgeMaybe(arrayExpr.getText, identifier) | ||
| val identifierAst = astsForExpression(arrayExpr, None) |
Contributor
There was a problem hiding this comment.
Variable name should also be updated. Something like baseExpression seems appropriate.
Comment on lines
84
to
90
| "should contain a listOf Call with the correct arguments" in { | ||
| cpg.call.name("listOf").length shouldBe 1 | ||
| val List(call) = cpg.call.name("listOf").l | ||
| call.argument.length shouldBe 3 | ||
| call.argument(1).code shouldBe "1" | ||
| call.argument(2).code shouldBe "2" | ||
| call.argument(3).code shouldBe "3" |
Contributor
There was a problem hiding this comment.
This call to listOf could be anywhere in the CPG.
The test would have much better form if you start by selecting the array access call, expand to argument 0 and check if that is a call to listOf. From there you can then check its arguments like you already do.
ml86
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.