Skip to content

feat: add repeat subtasks for repeating tasks #427 #2630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

StartAGarden
Copy link

@StartAGarden StartAGarden commented May 27, 2023

Description

The repeating tasks are updated so they include their sub-tasks.
Example Use Case: The user wants to add a task for a daily "Morning Routine" including several sub-tasks (steps of the routine), without having to re-add the sub-tasks every day.

Issues Resolved

#427

Check List

  • New functionality impemented.
  • New functionality includes testing.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there StartAGarden! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

@StartAGarden
Copy link
Author

StartAGarden commented May 27, 2023

@johannesjo Since this is my first time contributing, please let me know your thoughts on the following things:

  • Is there anything I overlooked or is the change really this simply?
  • Is this enough test coverage? If not could you tell me what/how the optimal test coverage should look like?
  • Any thoughts on compatibility with existing repeat-tasks? Do the old sub-tasks get deleted/detached or is there a change that a user will suddenly see 100 sub-tasks after updating because he/she kept adding subtasks?

Thank you!

@johannesjo
Copy link
Owner

Hi there! Thanks for opening this up! Have you tested your code? The only change (apart from the tests) is adding a property, which should not do anything.

@StartAGarden
Copy link
Author

Whoops, sorry for pushing too fast. Going to dive in some more over the next couple days :)

@StartAGarden StartAGarden marked this pull request as draft May 27, 2023 13:24
@aaylnx
Copy link

aaylnx commented Jun 4, 2023

Whoops, sorry for pushing too fast. Going to dive in some more over the next couple days :)

@StartAGarden, I hope you're able to make some progress with this. This is one of those features I'm really hoping to see implemented in SP. Thanks for seeking to implement this.

@StartAGarden
Copy link
Author

New version here: #2659

@StartAGarden StartAGarden deleted the add-repeat-subtasks branch June 29, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants