Skip to content

Add sv translation #4097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Add sv translation #4097

wants to merge 24 commits into from

Conversation

joeax910
Copy link

@joeax910 joeax910 commented Mar 9, 2025

Added/started Swedish (sv) translation.

(Accidentally first added "se" instead of "sv" language and later removed it, plus had to wrestle a bit with inlang/Fink due to inexperience, which helps explain the messy commit history... My apologies!)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there joeax910! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

@johannesjo
Copy link
Owner

Hey there! Thank you very much for this!

Yes, fink is messing up unfortunately, also the other languages, which is not good :(

@NiklasBuchfink do you have any idea, why this might have happened?

@NiklasBuchfink
Copy link

@johannesjo @joeax910 I'm sorry I saw this far too late

What happened

  • CANCEL_FOCUS_SESSION got removed from the en.json file
  • The JSON plugin takes the sorting from the source language file (en.json file)
  • CANCEL_FOCUS_SESSION is moved to the end of all other language files, resulting in this diffing mess

Fix

Either you add the empty key to en.json again or you remove it from all files, then the problem should be solved.

@johannesjo
Copy link
Owner

@NiklasBuchfink is there any way to configure Fink to avoid these changes if there are no new translations to a language?

@NiklasBuchfink
Copy link

@johannesjo Not yet. It would be possible to extend the JSON plugin with an option for that, but it's not on our list at the moment.

We are open to merge a PR if you are willing to add the option

@johannesjo
Copy link
Owner

johannesjo commented Mar 30, 2025

@johannesjo Not yet. It would be possible to extend the JSON plugin with an option for that, but it's not on our list at the moment.

Alright! Thank you very much for your help.

Just for your information (I hope it doesn't sound harsh in any way): For the time being I might remove Fink from the project, since currently it does increase the work I have to personally spent on this. Even if it helps people to provide translations, they often mess up the files, bring merge issues and often contain a lot of commits.

@johannesjo
Copy link
Owner

@joeax910 I started attempting to merge this, but there are literally hundreds of conflicts. Could you maybe be so kind to take your changes and provide a fresh new PR from the master branch?

If you don't care about you showing up in the commit history of this repository, I can also manually merge this by hand.

@johannesjo
Copy link
Owner

ping @joeax910

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants