Skip to content

OpenProject Filter Fix #4166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

19Topgun93
Copy link

@19Topgun93 19Topgun93 commented Mar 23, 2025

Description

Describe what this change achieves

I have change the "open-project-api.service.ts". I have erase the filter parameter.

Issues Resolved

I cannot connect OpenProject with the actual Software. Without the filter I cane.

List any existing issues this PR resolves
#4142

Check List

  • [ x] New functionality includes testing.
  • New functionality has been documented in the README if applicable.

This is my first PR. So I hope this is allright. I only have erase the one part, and testet the software. But not heavy testing. But I didn't change anything else and the OpenProject connection is function now. So I think, it is all right.

King regards.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there 19Topgun93! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

@@ -52,19 +52,6 @@ export class OpenProjectApiService {
{
// see https://www.openproject.org/docs/api/endpoints/work-packages/
url: `${cfg.host}/api/v3/projects/${cfg.projectId}/work_packages`,
params: {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this will stop to work once you have more than 100 (pageSize) workPackages. Maybe there is a better way to fix this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will look into the filter API. I thought it is a cheap way. I'm not so into programming at the moment. I can read it and I learned it in my work, but I don't work as a developer. So I will try.

Copy link
Author

@19Topgun93 19Topgun93 Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested a little and add the params with pagesize 100 and sortBy updatedAt. I haven't get the filters parameter working. The Search doesn't filter at all. But for me that is better, then it doesn't work at all. Maybe my understanding from the filter parameter is bad. I don't know. Maybe a Dev with more experience then I can make it.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your effort! Currently I am very busy with some other features, so someone else picking this up, would be very welcome!

@johannesjo johannesjo added the needs work PRs that need additional changes. label Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs work PRs that need additional changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants