Fix Date Parser Accidentally Parsing Two-Digit Number as Year #4242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When user creates a new task which includes short syntax for date, then following by a two-digit number, the number will be interpreted as year.
For example: "Task
@
14/4 90m". Implication: User schedules the task for 14/4 going forward and estimates the task as taking 90 minutes. Two problems:Changes I've made:
DD/MM YY
. The regex pattern is more complicated than that, because there are so many ways a user can write date informally. It doesn't take into account syntax like "August 8 90m".parseScheduledDate
is changed so that the word "m" won't be a part of the final task title.Issues Resolved
Potentially fixes #4194
Check List