Skip to content

Fix #4184: Added fractional time parsing when creating a new task #4255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

sofialucasf
Copy link

Description

Fixed the issue #4184 where you could not insert 1.5h or any decimal value when inputing time stamp in the quick add method of creating a task. To test execute project with instructions given in the repository and add a new task (shift+A) and write the title of a new task such as "task 1.5h" or "task 1.5h/3.5h". Also added test cases for this fix.

Check List

  • [✅] New functionality includes testing.
  • [❌] New functionality has been documented in the README if applicable.

…w task

Fixed the issue where you could not insert 1.5h or any decimal value
when inputing time stamp in the quick add method of creating a task. To
test execute project with instructions given in the repository and add a
new task (shift+A) and write the title of a new task such as "task 1.5h"
or "task 1.5h/3.5h". Also added test cases for this fix.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there sofialucasf! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

@dosubot dosubot bot added the bug label Apr 14, 2025
@johannesjo
Copy link
Owner

Thank you very much!

@johannesjo johannesjo merged commit 4104270 into johannesjo:master Apr 15, 2025
6 checks passed
@sofialucasf
Copy link
Author

Thank you very much!

Thank you as well. It was really fun working on the project and as a first time contributor it was a great learning experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants