Add monthly featured developer showcase#124
Conversation
Highlights top GitHub developer each month based on engagement (followers, stars, repos, sponsors, activity). Features beautiful gradient banner with user stats and top languages. Auto-updates when running fetch.py. Current featured: Linus Torvalds (engagement score: 74.97) Resolves john-bampton#122
Summary of ChangesHello @Aashish-Jha-11, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant new feature to showcase a 'Featured Developer of the Month' on the platform. It encompasses both backend logic for selecting the developer based on a comprehensive engagement score and frontend UI/UX development to present this information attractively and responsively. The goal is to celebrate highly engaged community members and provide an engaging visual element to the site. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a great new feature: a monthly featured developer showcase. The implementation spans the frontend and backend, with new UI components, styling, and Python scripts for data processing. My review identifies a critical bug in fetch.py due to a duplicated function, which needs immediate attention. I've also pointed out a high-priority maintainability issue concerning duplicated logic between two Python scripts. Other comments focus on improving code quality and maintainability through better error handling, code structure, and adherence to standard coding practices. The frontend work is generally solid, with good considerations for performance and security.
|
@Aashish-Jha-11 shows me a screenshot once everything is ready. |
|
And I think we need to merge both json into one as in this case we will have some delay to load this big featured developer section and will make scroll changes for end-user. |
- Increased stat label font size and contrast for better readability - Removed indentation from featured.json (compact format) - Updated both fetch.py and generate_featured.py
Let me know your feedback about this. |
|
@BaseMax Sir! I think Keeping JSONs separate is better: Both load in parallel Promise.all & featured.json |
Did you handled it in manifest.json or service-worker.js file? |
|
@BaseMax Not explicitly - I meant browser-level caching. Separate files = independent cache entries. When featured.jsonupdates monthly, browsers can keep cached users.json (saves 640KB re-download). Should we add explicit cache handling in service-worker.js? We could set different cache durations (1 month for featured.json vs longer for users.json). |
Yes. |
|
1 months is too mcuh, lets set 1 week for featured, and 1 day for users.json. |
- featured.json: 1 week cache - users.json: 1 day cache - Adds timestamp tracking for cache validation
|
"Due to the large number of changes in this pull request, only one file is being shown at a time." something is wrong in this PR. |
|
This PR is open for a while, please finalize and do the task sooner so we can merge and have it up/ready. Thanks, and Happy Yalda Night. |
|
Hi @BaseMax Sir, thanks for the patience. The large diff is from prettier formatting bootstrap vendor files and users.json data file. Current blockers: I can resolve both quickly once I know the specific linter issues. The core feature code (~300 lines) is complete and tested. Happy Yalda Night! 🎉 |
|
This branch has conflicts that must be resolved |
1 similar comment
|
This branch has conflicts that must be resolved |
|
We need to close and merge it faster. @Aashish-Jha-11 please do action. |
|
Hi @BaseMax, understood - I'll act immediately Please tell me your opinion then only i would be able to proceed please. Two options to close this fast: Revert to working stage 1 (before lint changes) - this auto-fixes conflicts and gives clean feature-only code |
|
Please make sure you pull from latest version of main and fix all conflicts. Complete your PR, I want to merge and develop it more. Best |
I already updated pre-commit on the main branch, and it will run linters, etc so don't change formats of code at all. pre-commit will take care of it for now. |
|
Here's the code health analysis summary for commits Analysis Summary
|
|
This branch has conflicts that must be resolved |
|
Hi @BaseMax, Resolved merge conflicts and fixed all critical issues in our feature code. Latest commit: 4e08e3b Fixed: Still failing (DeepSource): JS-0125 (Undeclared variables) - jQuery/Bootstrap patterns Options: Exclude vendor files from DeepSource analysis |
|
docs/bootstrap/css/bootstrap-grid.css all bootstrap assets files should be minify. |
|
If we have both .min.css and nonmin.css so please remove nonmin and just keep using .min.css or .min.js. |
|
you should keep docs/featured.json file minified. |
|
you should keep docs/manifest.json file minified. or maybe this comes from pre-commit or something? |
|
I will not merge it, you damaged to my recent updates such as |
|
If it's hard for you to check/fix conflicts with pay attention to details. i suggest you to close this pr and open a new one and just copy paste your important/new changes |
|
I have removed nonmin css and js bootstrap files in main branch. |
|
Closing this PR due to merge conflict damage. Replaced with clean implementation in #187 |





Highlights top GitHub developer each month based on engagement (followers, stars, repos, sponsors, activity). Features beautiful gradient banner with user stats and top languages. Auto-updates when running fetch.py.
Current featured: Linus Torvalds (engagement score: 74.97)
What's included:
fetch.pygenerate_featured.pyResolves #122