Max updates: super turbo mode#173
Conversation
Summary of ChangesHello @BaseMax, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the HTML minification utility by introducing a more sophisticated approach to handling JavaScript content within <script> tags. The core improvement ensures that only inline JavaScript is minified, preventing potential issues that could arise from minifying external scripts referenced via the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Here's the code health analysis summary for commits Analysis Summary
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves the HTML minification process by correctly handling <script> tags. The previous implementation would strip attributes from all script tags, breaking external scripts that use the src attribute. The new logic correctly identifies script tags with a src attribute and leaves them untouched, while still minifying inline scripts and preserving their attributes. This is a great fix. I've added one suggestion to make the src attribute detection more robust and the helper function a bit more concise.
…time.utcnow().strftime('%a, %d %b %Y %H:%M:%S GMT'),
|
cc #166 |
|
cc #171 |
|
cc #172 |
|
cc #168 |
|
cc #163 |
…ned in the outer scope, making it inaccessible and might confuse
|
cc #157 |
|
cc #152 |
|
cc #148 |
…cape=False detected
|
cc #151 |
|
cc #138 |
|
cc #129 |
|
cc #174 |
…urns, or none of them JS-0045
|
https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json So we will use 3.14.2 3.15 is beta yet. |
|
cc #175 |
BaseMax
changed the title
1 participant
No description provided.