Max updates super mode

[BaseMax]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @BaseMax, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on bolstering the project's foundational elements by enhancing code quality, strengthening security measures, and introducing new web standards for better discoverability. It streamlines development workflows through automated formatting and provides users with an improved, more robust experience, including better offline support and content syndication.

Highlights

• Code Quality & Formatting: Integrated black and isort into pre-commit hooks to enforce consistent Python code formatting and import sorting, significantly improving code readability and maintainability.
• Security Enhancements: Introduced safe_path and download_file_http functions in fetch.py to prevent path traversal vulnerabilities and ensure secure, HTTP(S)-only file downloads, replacing less secure methods.
• New Web Features: Added automatic generation of an RSS feed (feed.xml) and a sitemap (sitemap.xml), enhancing content discoverability and SEO for the project website.
• Service Worker Improvements: Refactored the service worker logic to include versioning, explicit cache expiration for dynamic content like users.json, and clearer cache management functions, improving offline experience and data freshness.
• Documentation Update: The README.md has been extensively revised to detail new features, provide a clearer quickstart guide, outline development and quality standards, and explain the new RSS feed functionality.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files

• Ignored by pattern: .github/workflows/** (3)
  • .github/workflows/fetch-daily.yml
  • .github/workflows/pre-commit.yml
  • .github/workflows/render-on-push.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[deepsource-io]

Here's the code health analysis summary for commits e0afffb..8edd3ed. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
Secrets	✅ Success		View Check ↗
Python	❌ Failure	❗ 1 occurence introduced 🎯 1 occurence resolved	View Check ↗
JavaScript	✅ Success		View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[gemini-code-assist]

Code Review

This pull request introduces significant improvements, including a revamped README, new pre-commit hooks for code quality, and crucial security enhancements in fetch.py. The service worker has also been refactored for better caching logic. My review focuses on a few areas for improvement: I've identified a high-severity bug in render.py that will prevent sitemap generation, a potential regression in the service worker's caching strategy, some code duplication between scripts, and a minor documentation error. Addressing these points will further enhance the quality and robustness of the codebase.

I am having trouble creating individual review comments. Click here to see my feedback.

render.py (274-277)

There's a bug in the sitemap generation logic. The generate_sitemap_xml function is called with a relative filename ("sitemap.xml"), but the safe_path check inside it expects a path within the ./docs directory. This will cause the check to fail and raise a ValueError, preventing the sitemap from being created.

To fix this, you should construct the full path to the sitemap file within the docs directory before passing it to the function.

        sitemap_path = os.path.join(SITE_DIR, "sitemap.xml")
        sitemap_urls = list({item.get("guid", item.get("link", main_url)) for item in rss_items})
        sitemap_urls.append(DEPLOY_BASEURL + "/feed.xml")
        generate_sitemap_xml(sitemap_urls, sitemap_path)

fetch.py (97)

The docstring for setup_logger appears to be incorrect. It states it's for "HTML rendering," which seems to be a copy-paste from render.py. This should be updated to reflect that the logger is for the user fetching process to avoid confusion.

    """Initialize and configure logger for GitHub user fetching."""

render.py (51-57)

The safe_path function is duplicated in both fetch.py and render.py. To improve maintainability and adhere to the DRY (Don't Repeat Yourself) principle, this function should be extracted into a shared utility file (e.g., utils.py) and imported where needed.

docs/service-worker.js (54-58)

The refactored handleDefaultFetch function implements a cache-first strategy but no longer updates the cache with new responses from the network. The previous implementation cached same-origin responses (like avatars) in a RUNTIME cache. This change is a potential regression, as resources fetched at runtime will not be cached by the service worker, which could negatively impact the offline experience and performance on subsequent visits.

If the intention is to cache these runtime assets, consider updating the function to populate the cache after a network fetch, for example:

function handleDefaultFetch(event) {
  event.respondWith(
    caches.open(PRECACHE).then(cache => {
      return cache.match(event.request).then(cachedResponse => {
        return cachedResponse || fetch(event.request).then(networkResponse => {
          cache.put(event.request, networkResponse.clone());
          return networkResponse;
        });
      });
    })
  );
}