Skip to content

Max updates super3 2025 12 25#184

Merged
BaseMax merged 34 commits into
john-bampton:mainfrom
MaxFork:max-updates-super3-2025-12-25
Dec 25, 2025
Merged

Max updates super3 2025 12 25#184
BaseMax merged 34 commits into
john-bampton:mainfrom
MaxFork:max-updates-super3-2025-12-25

Conversation

@BaseMax

@BaseMax BaseMax commented Dec 25, 2025

Copy link
Copy Markdown
Member

No description provided.

BaseMax and others added 30 commits December 25, 2025 10:12
…time.utcnow().strftime('%a, %d %b %Y %H:%M:%S GMT'),
…ned in the outer scope, making it inaccessible and might confuse
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @BaseMax, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the project's web presence and maintainability. it introduces a robust mechanism for generating and exposing a sitemap to search engines, alongside better integration of the existing RSS feed. concurrently, it streamlines the project's CSS dependencies by removing specific Bootstrap grid and reboot stylesheets.

Highlights

  • Sitemap Generation: Implemented automatic generation of "sitemap.xml" to enhance search engine optimization and site discoverability.
  • RSS Feed Integration: The RSS feed is now explicitly linked in the HTML layout via a "<link rel="alternate">" tag, improving its discoverability for feed readers.
  • Bootstrap CSS Removal: Removed "bootstrap-grid.css" and "bootstrap-reboot.css" files, potentially indicating a refactor of styling or a move away from Bootstrap components.
  • robots.txt Configuration: A new "robots.txt" file has been added, which directs search engine crawlers to the newly generated "sitemap.xml".

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@BaseMax BaseMax merged commit 9f57978 into john-bampton:main Dec 25, 2025
2 of 6 checks passed
@deepsource-io

deepsource-io Bot commented Dec 25, 2025

Copy link
Copy Markdown
Contributor

Here's the code health analysis summary for commits c5b753d..bd4f32d. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Secrets LogoSecrets✅ SuccessView Check ↗
DeepSource Python LogoPython✅ Success
🎯 1 occurence resolved
View Check ↗
DeepSource JavaScript LogoJavaScript✅ Success
🎯 819 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces sitemap generation, updates the README, and removes some unused Bootstrap files. The core logic for generating the sitemap has a potential security vulnerability due to manual XML construction and also a functional issue where it creates an incomplete sitemap. I've provided two high-severity comments with suggestions to address these issues in render.py.

I am having trouble creating individual review comments. Click here to see my feedback.

render.py (40-43)

high

Manually constructing XML with f-strings is not robust and can be a security risk if the urls list ever contains user-provided data (XML injection). It can also lead to malformed XML if a URL contains special characters like &, <, or >. As a minimal fix, you should escape the URL content using html.escape(). For a more robust solution, consider using a dedicated XML library like xml.etree.ElementTree.

Note: You will need to add import html at the top of the file.

    urlset = "\n".join(
        f"    <url>\n        <loc>{html.escape(url)}</loc>\n    </url>" for url in urls
    )
    sitemap = f"""<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<urlset xmlns=\"http://www.sitemaps.org/schemas/sitemap/0.9\">\n{urlset}\n</urlset>\n"""

render.py (274-277)

high

The generated sitemap currently only includes the main page URL and the RSS feed URL. For better SEO and discoverability, the sitemap should include the URLs for all the individual user profiles. You can achieve this by iterating through the users list and adding their html_url to the sitemap_urls.

Additionally, "sitemap.xml" is a "magic string". It's better to define this as a constant at the top of the file for maintainability.

        sitemap_filename = "sitemap.xml"
        sitemap_urls = {f"{DEPLOY_BASEURL}/", f"{DEPLOY_BASEURL}/feed.xml"}
        sitemap_urls.update(user["html_url"] for user in users if user.get("html_url"))
        generate_sitemap_xml(list(sitemap_urls), sitemap_filename)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant