pre-commit clean up; remove duplicate black

[jbampton]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @jbampton, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the project's pre-commit configuration. It updates the isort dependency to its latest version and removes an explicit black formatter hook, likely to avoid duplication or to align with an existing, more centralized black configuration. The overall goal is to ensure a cleaner and more up-to-date pre-commit environment.

Highlights

• Pre-commit Configuration Update: The isort pre-commit hook has been updated from version 5.12.0 to 7.0.0.
• Duplicate Black Hook Removal: A redundant black pre-commit hook definition has been removed from the configuration, streamlining the pre-commit setup.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[cloudflare-workers-and-pages]

Deploying john-bampton with    Cloudflare Pages

Latest commit:	bbe52ff
Status:	✅  Deploy successful!
Preview URL:	https://6ae1c4ae.john-bampton.pages.dev
Branch Preview URL:	https://pre-commit-clean-up.john-bampton.pages.dev

View logs

[gemini-code-assist]

Code Review

This pull request updates the isort pre-commit hook and removes the black hook. The removal of black seems to be based on a misunderstanding of how isort's black profile works. This profile ensures compatibility but does not run the black formatter itself. Removing the black hook will stop automatic code formatting, potentially leading to inconsistent code style across the project. I've left a comment recommending that the black hook be restored.

I am having trouble creating individual review comments. Click here to see my feedback.

.pre-commit-config.yaml (32-39)

Removing the black pre-commit hook appears to be based on a misunderstanding. The PR title mentions removing a 'duplicate', likely assuming that isort's profile = "black" also runs the black formatter. However, this isort profile only ensures its output is compatible with black's formatting; it does not execute black. To maintain the project's code style (which is configured in pyproject.toml), the black hook is necessary and should be kept in this pre-commit configuration.

[deepsource-io]

Here's the code health analysis summary for commits f63ff75..bbe52ff. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
Secrets	✅ Success		View Check ↗
Python	✅ Success		View Check ↗
JavaScript	✅ Success		View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.