Skip to content

Add 8 pygrep pre-commit hooks#199

Merged
jbampton merged 1 commit into
mainfrom
more-pre-commit
Dec 26, 2025
Merged

Add 8 pygrep pre-commit hooks#199
jbampton merged 1 commit into
mainfrom
more-pre-commit

Conversation

@jbampton

Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @jbampton, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the project's code quality and documentation consistency by introducing a suite of new pre-commit hooks. It integrates isort for automated Python import sorting and adds eight pygrep-hooks to enforce best practices in Python code and reStructuredText documentation, alongside a fix for an existing RST formatting issue. These changes aim to improve maintainability and readability across the codebase.

Highlights

  • Pre-commit Hooks: Integrated the isort pre-commit hook to automatically sort Python imports, ensuring consistent code style.
  • Code Quality Checks: Added eight new pygrep-hooks to enforce various code quality standards, including checks for mock method usage, eval() function, deprecated logger.warn(), and proper Python type annotations.
  • Documentation Formatting: Introduced pygrep-hooks for reStructuredText (RST) documentation, specifically to detect common formatting mistakes like incorrect backticks, directive colons, and inline text spacing.
  • Unicode Character Check: Included a pygrep-hook to forbid files containing UTF-8 Unicode replacement characters, preventing potential encoding issues.
  • RST Formatting Fix: Corrected a reStructuredText formatting error in doc/source/index.rst by changing single backticks to double backticks for an inline code directive.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@jbampton jbampton added this to Turbo Dec 26, 2025
@jbampton jbampton moved this to In Progress in Turbo Dec 26, 2025
@jbampton jbampton added this to the December - January 2025 milestone Dec 26, 2025

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds several pygrep pre-commit hooks to improve code quality and consistency, and also moves the isort hook to a more appropriate position before black. The changes also include a fix in an .rst file, which is a good improvement. My review includes a critical fix for an invalid hook version and a suggestion to simplify the new hook configurations for better maintainability.

Comment thread .pre-commit-config.yaml
Comment thread .pre-commit-config.yaml
@jbampton jbampton merged commit ae2face into main Dec 26, 2025
3 checks passed
@jbampton jbampton deleted the more-pre-commit branch December 26, 2025 13:31
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Turbo Dec 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant