Skip to content

Add yamllint to pre-commit; clean up#201

Merged
jbampton merged 2 commits into
mainfrom
add-yamllint
Dec 26, 2025
Merged

Add yamllint to pre-commit; clean up#201
jbampton merged 2 commits into
mainfrom
add-yamllint

Conversation

@jbampton

Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @jbampton, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances code quality and consistency by integrating yamllint into the pre-commit workflow. This ensures that all YAML files adhere to predefined style guidelines before being committed, preventing common formatting issues and improving readability across the project. Additionally, a minor cleanup was performed in the Dependabot configuration.

Highlights

  • yamllint Integration: yamllint has been added as a new pre-commit hook to enforce consistent YAML formatting and style across the repository.
  • Pre-commit Configuration Update: The .pre-commit-config.yaml file was updated to include the yamllint hook, configured to run in strict mode and utilize a custom linting configuration file located at .github/linters/.yaml-lint.yml.
  • Minor File Cleanup: A trailing blank line was removed from the .github/dependabot.yml file, contributing to minor file cleanup.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/render-on-push.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Dec 26, 2025

Copy link
Copy Markdown

Deploying john-bampton with  Cloudflare Pages  Cloudflare Pages

Latest commit: 436e44a
Status: ✅  Deploy successful!
Preview URL: https://721881c3.john-bampton.pages.dev
Branch Preview URL: https://add-yamllint.john-bampton.pages.dev

View logs

@jbampton jbampton self-assigned this Dec 26, 2025
@jbampton jbampton added this to Turbo Dec 26, 2025
@jbampton jbampton moved this to In Progress in Turbo Dec 26, 2025
@jbampton jbampton added this to the December - January 2025 milestone Dec 26, 2025
@deepsource-io

deepsource-io Bot commented Dec 26, 2025

Copy link
Copy Markdown
Contributor

Here's the code health analysis summary for commits ae2face..436e44a. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Secrets LogoSecrets✅ SuccessView Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds yamllint to the pre-commit configuration to enforce YAML file standards and includes a minor cleanup in the dependabot.yml file. The addition of yamllint is a great step for maintaining code quality. I've provided one suggestion in .pre-commit-config.yaml to use a stable version of yamllint and to simplify the hook configuration for better maintainability.

Comment thread .pre-commit-config.yaml
@jbampton jbampton merged commit b3ae2aa into main Dec 26, 2025
9 checks passed
@jbampton jbampton deleted the add-yamllint branch December 26, 2025 13:55
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Turbo Dec 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant