Opt "About Me" into typography styles piecemeal #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove global paragraph style * Remove global style undo hack * Sync from upstream resume * Wrap Markdown content that should have the old styles in `<div class="post">` Previously, with global styles, the custom "Experience" section of the "About Me" page was riddled with inconsistencies with the upstream resume, in presentation and code. Applying typography styles piecemeal allows the "About Me" page to better stay in sync.
john-kurkowski
commented
Mar 27, 2025
| @@ -6,6 +6,8 @@ title: 'About Me' | |||
| import Experience from '../components/resume/experience.astro' | |||
| import Time from '../components/resume/time.astro' | |||
|
|
|||
| <div class="post"> | |||
There was a problem hiding this comment.
Scattering these <div>s is clumsy though. I wonder if that's the trade-off to accept, or if there's a better way.
There was a problem hiding this comment.
There is an eject button, to override whenever Markdown encounters standard tags like p with a custom component. See this example with Tailwind classes in Astro.
It'd be a lot at the moment to port the global typography styles to that new way of doing things. So I'll stick with this line's CSS cascade for now.
|
Highlights this chunk of the "About Me" page as different. Removes the need to escape the content as not Markdown, i.e. surround in curly braces.
❗ page/about__[w1280px]:
❗ page/about__[w414px]:
|
"Astro is not like JSX." This Prettier-style wrapping generated unwanted additional link underline.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, with global styles, the custom "Experience" section of the "About Me" page was riddled with inconsistencies with the upstream resume, in presentation and code. Applying typography styles piecemeal allows the "About Me" page to better stay in sync.
Changes
<div class="post">