vaillant: add RunDataFlowTemp + RunDataReturnTemp to 08.hmu.HW5103#599
Open
buliwyf42 wants to merge 1 commit into
Open
vaillant: add RunDataFlowTemp + RunDataReturnTemp to 08.hmu.HW5103#599buliwyf42 wants to merge 1 commit into
buliwyf42 wants to merge 1 commit into
Conversation
PR john30#496 (merged 2025-04-12) added RunDataFlowTemp and RunDataReturnTemp to src/vaillant/08.hmu.tsp. The HW=5103 firmware variant has its own file (08.hmu.HW5103.tsp) that does not import from 08.hmu.tsp, so HW=5103 owners — explicitly the hardware @roe-lz called out in john30#446 ("These work on MF=Vaillant;ID=HMU00;SW=0902;HW=5103") — never received the new entities. Live verification on a HW=5103/SW=0902 unit: RunDataFlowTemp = 31.29 °C RunDataReturnTemp = 31.05 °C (matches the existing flowtemp / status01_temp + status01_temp_1 readings within sensor tolerance, but at higher precision because tempv is EXP rather than D1C) Verification: - npx tsp compile --emit @ebusd/ebus-typespec --warn-as-error exits 0 - ebusd --checkconfig with the compiled CSV exits 0 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
@john30 I'd like these two values to be added, too. They work (tested), and are relevant values on the HW5103. One of these I have been actively using. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #496 (merged 2025-04-12) added
RunDataFlowTempandRunDataReturnTemptosrc/vaillant/08.hmu.tsp. The HW=5103 firmware variant has its own file (08.hmu.HW5103.tsp) that does not import from08.hmu.tsp, so HW=5103 owners — explicitly the hardware @roe-lz called out in #446 ("These work onMF=Vaillant;ID=HMU00;SW=0902;HW=5103") — never received the new entities.This adds the two models to
08.hmu.HW5103.tspso the same telemetry is available on HW=5103 systems.Live verification (
HW=5103;SW=0902)Both consistent with the existing
flowtemp/status01_temp+status01_temp_1readings within sensor tolerance, but at higher precision becausetempvisEXPrather thanD1C.Build
npx tsp compile --emit @ebusd/ebus-typespec --warn-as-errorexits 0ebusd --checkconfigwith the compiled CSV exits 0Diff
@inherit(r_7) @ext(0xde, 0x8) model RunDataAirInletTemp { value: tempv; } + @inherit(r_7) + @ext(0xfc, 0x8) + model RunDataFlowTemp { + /** current flow temp, accurate to 2 decimal places */ + value: tempv; + } + + @inherit(r_7) + @ext(0x6, 0x9) + model RunDataReturnTemp { + /** current return temp, accurate to 2 decimal places */ + value: tempv; + } + // B516Same
r_7base, sametempvtype, same@extbytes as the generic08.hmu.tsp.