-
-
Notifications
You must be signed in to change notification settings - Fork 28
Update dependencies #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #105
Conversation
👷 Deploy request for coronate accepted.
|
src/Externals/Numeral.res
Outdated
Pull requests and bug reports are welcome! */ | ||
type t | ||
@get external getHelpers: numeral => t = "_" | ||
// module Helpers = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't get these to compile at all, no idea why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh. This code was always pretty messy and I don't recall the details of how/why I designed it now. I can try to take a look at it later when I get a chance.
727d524
to
84fd5b0
Compare
After updating the test files, there seems to be some issues with the |
Yeah I think the modern approach would be to switch the whole build to Should I continue on this PR or is this "mergable" even though some tests and the "Externals/Numeral.rs" is still outstanding? |
After thinking about it, I decided to simply remove the I'm happy to merge this and address the test suite and build system in a separate PR. Since the live site is built from the master branch, I'm first going to double-check that there aren't any obvious quirks in the build before merging though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you for working on this!
No description provided.