Add support for specifying a command in browser configurations #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce a new `command` option in `BrowserOpts` to allow specifying a custom command to open URLs. - Update `AppDescriptor` and relevant methods to handle the new `command` type. - Modify the `getBrowserCommand` function to prioritize `command` over app paths and bundle IDs. - Update configuration schema validations to include the new `command` attribute. - Add logging for URLs, bundle IDs, and app paths for better debugging. - Bump `CFBundleVersion` from 319 to 336 in `Info.plist`.
|
This looks interesting! I'm about half way through a rewrite of Finicky, and I'll have a closer look at this in a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commandoption inBrowserOptsto allow specifying a custom command to open URLs.AppDescriptorand relevant methods to handle the newcommandtype.getBrowserCommandfunction to prioritizecommandover app paths and bundle IDs.commandattribute.CFBundleVersionfrom 319 to 336 inInfo.plist.