Merged
Conversation
…to bugfix/snap_geocode_cal
…to feature/ers_envisat
…to feature/ers_envisat
…to feature/ers_envisat
…to feature/ers_envisat
Pull Request Test Coverage Report for Build 18854125071Details
💛 - Coveralls |
…on, not SAR-Simulation
… apply to the product)
…to feature/ers_envisat
…to feature/ers_envisat # Conflicts: # pyroSAR/gamma/util.py
…to feature/ers_envisat # Conflicts: # pyroSAR/gamma/util.py
…rodt/pyroSAR into feature/ers_envisat
…to feature/ers_envisat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements several changes to enable/improve ERS and Envisat processing..
snapauxil.orb_parametrize: improved ERS/ASAR orbit handling (more work necessary to always select the best available file, because all options are limited in time (e.g. use option 1 if possible, fall back to option 2 otherwise, etc.); needs a download functionality likeS1.auxil.OSVto know which ones are available)util.geocode:Calibrationin/out band handling improvementsFalseSAR-Simulation->Cross-Correlation->Terrain-Flattening->SARSim-Terrain-Correction(does not work becauseTerrain-Flatteningdoes not pass through any source layers)SAR-Simulation->Cross-Correlation->Warp->Terrain-Flattening->Terrain-CorrectionWarpstep introduces unnecessary resampling, the created lookup table is not passed between operators and thus makes the process inefficient, the whole procedure only works with EPSG:4326 as map geometry thus, by the looks of it, requiring three forward geocoding steps (forSAR-Simulation,Terrain-FlatteningandTerrain-Correction, respectively)auxil.groupbyWorkers: addWarpoperator to the group of its source node, because it cannot be executed alone (just likeThermalNoiseRemoval)SAR-Simulation, but the output layer is named differently ('layover_shadow_mask' instead of 'layoverShadowMask' byTerrain-Correction); this must be handled correctly inauxil.writerdriversESA:scan_Metadata:meta['origin']frameNumberinstead of product counter (which often seems to be 0)incidenceAngleMin->incidence_nrincidenceAngleMax->incidence_frrangeResolution,azimuthResolution->resolution(tuple)neszNear,neszFar->nesz(tuple)geo_grid(like forSAFE)acquisition_modefor ASAR WSM, WSSBEAM_DIMAPincidenceAngleMidSwathnot always present, useincidence_nearandincidence_faralternativelyorbit_cycleorCYCLEframeNumber, useABS_ORBIT, notdata_take_idas for Sentinel-1metaattributes:swath,looksPolarizationsfields present, some may be set to None -> filtered outACQUISITION_MODEandPRODUCT_TYPErespectively; for ASAR/ERSACQUISITION_MODEis missing andPRODUCT_TYPEcontains the original values, e.g. 'ASA_APP_1P' -> must be abstractedIDstart_dtandstop_dtreturning timezone-aware datetime objectsancillary:multilook_factors: fixed bug in returning 0 as range factor