Skip to content

ancillary.multilook_factors: reimplementation#371

Merged
johntruckenbrodt merged 1 commit intomainfrom
bugfix/ml_factors
Dec 8, 2025
Merged

ancillary.multilook_factors: reimplementation#371
johntruckenbrodt merged 1 commit intomainfrom
bugfix/ml_factors

Conversation

@johntruckenbrodt
Copy link
Copy Markdown
Owner

@johntruckenbrodt johntruckenbrodt commented Nov 26, 2025

The old implementation failed in cases where the range spacing is larger than the azimuth spacing and the target spacing.

Example:

rglks, azlks = multilook_factors(
    source_rg=7.8,
    source_az=4.1,
    target=10,
    geometry="SLANT_RANGE",
    incidence=23.3
)

old:

  • factors (1, 2)
  • ground range spacing (19.72, 8.2)

new:

  • factors (1, 5)
  • ground range spacing (19.72, 20.5)

The new approach now tries to equally minimize the difference between

  • output azimuth spacing and target spacing
  • output range spacing and target spacing
  • output range and azimuth spacing

The pixel is thus as close to the target spacing as possible in both range and azimuth and as "square" as possible.

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 19705459105

Details

  • 35 of 38 (92.11%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.0%) to 54.008%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyroSAR/ancillary.py 35 38 92.11%
Files with Coverage Reduction New Missed Lines %
pyroSAR/S1/auxil.py 1 42.31%
Totals Coverage Status
Change from base Build 19334028516: 1.0%
Covered Lines: 3989
Relevant Lines: 7386

💛 - Coveralls

@johntruckenbrodt johntruckenbrodt merged commit b787937 into main Dec 8, 2025
4 checks passed
@johntruckenbrodt johntruckenbrodt deleted the bugfix/ml_factors branch February 4, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants