[convert2gamma] fix S1 GRD thermal noise removal#416
Merged
johntruckenbrodt merged 1 commit intomainfrom Mar 24, 2026
Merged
Conversation
Pull Request Test Coverage Report for Build 23494595113Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back when the S1 GAMMA import functionality was developed, it was assumed in GAMMA that noise was already removed in GRDs and specifying the XML file meant adding it back to the data.
This had changed in July 2015 but pyroSAR never changed with it. Hence, thermal noise was not subtracted from the data on import.
This has now finally been discovered and fixed.