fix: add fetch_lyrics param to search_album#335
Merged
Conversation
Adds fetch_lyrics: bool = True to search_album(). When False, lyrics scraping is skipped for all tracks, returning only metadata. Reduces time for a 10-track album from ~12s to ~2s. Fixes #217
johnwmillr
force-pushed
the
fix/fetch-lyrics
branch
from
e0bde42 to
9bdd6b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #217
search_album()was unconditionally scraping lyrics for every track, even whenget_full_info=False. This gave users no way to opt out of the expensive per-track web scraping step.Changes
fetch_lyrics: bool = Trueparameter tosearch_album()False, skips thelyrics()call for all tracks and returns empty strings insteadtests/test_album.pyPerformance impact
On a 10-track album (The Party by Andy Shauf):
fetch_lyrics=False)Usage