Multiple fixes and improvements#2
Merged
Merged
Conversation
Capture the activity once and reject the call if null; re-check the window inside the UI-thread lambda. Avoids NPEs when the activity is torn down between scheduling and executing the flag update.
UIApplication.shared.windows is deprecated and returns windows across all scenes, which picks the wrong one in iPad split-view and multi-window apps. Walk connectedScenes to find the foreground window scene's key window, falling back to foregroundInactive since willResignActive can fire after the scene leaves the active state.
Gustavo Hoirisch (gugahoi)
requested a review
from Harrison Rouillard (harrison-flux)
April 23, 2026 04:32
Contributor
Author
|
I can cut a new release after we review and merge this |
Harrison Rouillard (harrison-flux)
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1