Skip to content

Template based DNS client architecture#185

Merged
mrabine merged 8 commits into
mainfrom
184-introduce-template-based-dns-architecture
Apr 17, 2026
Merged

Template based DNS client architecture#185
mrabine merged 8 commits into
mainfrom
184-introduce-template-based-dns-architecture

Conversation

@mrabine

@mrabine mrabine commented Apr 17, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@mrabine mrabine linked an issue Apr 17, 2026 that may be closed by this pull request
@codacy-production

codacy-production Bot commented Apr 17, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 178 complexity · 11 duplication

Metric Results
Complexity 178
Duplication 11

View in Codacy

🟢 Coverage 92.86% diff coverage · -0.05% coverage variation

Metric Results
Coverage variation -0.05% coverage variation
Diff coverage 92.86% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (56f463a) Report Missing Report Missing Report Missing
Head commit (fe00e56) 10803 (+67) 10411 (+59) 96.37% (-0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#185) 560 520 92.86%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

1 Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

TIP This summary will be updated as you push new changes. Give us feedback

@codecov

codecov Bot commented Apr 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.96296% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.36%. Comparing base (56f463a) to head (fe00e56).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
fabric/include/join/dnsbase.hpp 87.37% 25 Missing ⚠️
fabric/include/join/resolver.hpp 95.85% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
- Coverage   96.46%   96.36%   -0.10%     
==========================================
  Files          90       91       +1     
  Lines       10043    10129      +86     
==========================================
+ Hits         9688     9761      +73     
- Misses        355      368      +13     
Flag Coverage Δ
unittests 96.36% <92.96%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls

coveralls commented Apr 17, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 24568597015

Coverage decreased (-0.05%) to 96.371%

Details

  • Coverage decreased (-0.05%) from the base build.
  • Patch coverage: 40 uncovered changes across 2 files (520 of 560 lines covered, 92.86%).
  • 1 coverage regression across 1 file.

Uncovered Changes

File Changed Covered %
fabric/include/join/dnsbase.hpp 200 175 87.5%
fabric/include/join/resolver.hpp 330 315 95.45%

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
core/include/join/socket.hpp 1 89.59%

Coverage Stats

Coverage Status
Relevant Lines: 10803
Covered Lines: 10411
Line Coverage: 96.37%
Coverage Strength: 116076.95 hits per line

💛 - Coveralls

@mrabine
mrabine merged commit 6799fe2 into main Apr 17, 2026
13 checks passed
@mrabine
mrabine deleted the 184-introduce-template-based-dns-architecture branch April 17, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce Template-based DNS Architecture

2 participants