Skip to content

Add mDNS support#191

Merged
mrabine merged 17 commits into
mainfrom
190-add-mdns-support
May 9, 2026
Merged

Add mDNS support#191
mrabine merged 17 commits into
mainfrom
190-add-mdns-support

Conversation

@mrabine

@mrabine mrabine commented May 8, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@mrabine mrabine linked an issue May 8, 2026 that may be closed by this pull request
@mrabine
mrabine marked this pull request as draft May 8, 2026 08:02
@codacy-production

codacy-production Bot commented May 8, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 137 complexity · 48 duplication

Metric Results
Complexity 137
Duplication 48

View in Codacy

🟢 Coverage 97.77% diff coverage · +0.23% coverage variation

Metric Results
Coverage variation +0.23% coverage variation
Diff coverage 97.77% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8d5ed7c) 11098 10691 96.33%
Head commit (5cafb85) 11347 (+249) 10957 (+266) 96.56% (+0.23%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#191) 314 307 97.77%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented May 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.97297% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.56%. Comparing base (8d5ed7c) to head (5cafb85).

Files with missing lines Patch % Lines
fabric/include/join/resolver.hpp 66.66% 3 Missing ⚠️
fabric/src/netlinkmanager.cpp 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
+ Coverage   96.32%   96.56%   +0.24%     
==========================================
  Files          91       91              
  Lines       10410    10639     +229     
==========================================
+ Hits        10027    10274     +247     
+ Misses        383      365      -18     
Flag Coverage Δ
unittests 96.56% <97.97%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls

coveralls commented May 9, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 25606975681

Coverage increased (+0.2%) to 96.563%

Details

  • Coverage increased (+0.2%) from the base build.
  • Patch coverage: 7 uncovered changes across 3 files (307 of 314 lines covered, 97.77%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
fabric/include/join/resolver.hpp 9 6 66.67%
fabric/src/netlinkmanager.cpp 13 10 76.92%
fabric/include/join/nameserver.hpp 263 262 99.62%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 11347
Covered Lines: 10957
Line Coverage: 96.56%
Coverage Strength: 110144.06 hits per line

💛 - Coveralls

@mrabine
mrabine marked this pull request as ready for review May 9, 2026 15:17
@mrabine
mrabine merged commit bb06992 into main May 9, 2026
15 checks passed
@mrabine
mrabine deleted the 190-add-mdns-support branch May 9, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add mDNS support

2 participants