chore(v2): separate private mode from display mode #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmjohnso
changed the title
zmjohnso
changed the title
|
LGTM |
theborakompanioni
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses task #954.
The
src/hooks/useDisplayMode.tshook'sDisplayModetype was broken up into aCurrencytype and a simpleisPrivateboolean. Doing so simplifies the logic where most of the time, we only care about toggling the currency type. This also greatly cleans up the logic in places likesrc/components/settings/Settings.tsx, where the separation of types is more apparent. While the individual toggles were separated, there is still atoggleDisplayModefor swapping between the three "display modes" on the landing page. Maybe there is still a cleaner way to do this? Also, the naming conventions could possibly still be improved. I usedcurrency: Currency, butbitcoinUnits: BitcoinUnitsmight make more sense.