Skip to content

refactor: currency symbol and amount format #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 11, 2025
Merged

refactor: currency symbol and amount format #980

merged 6 commits into from
Oct 11, 2025

Conversation

theborakompanioni
Copy link
Collaborator

Small refactoring:

  • proper names for currency symbol (DisplayLogo -> CurrencySymbol, getLogo -> currencySymbol)
  • small improvements to formatting (e.g. vertically centered smybol for "private" balance) -> still needs love
  • display wallet name on landing page and navbar

@theborakompanioni theborakompanioni self-assigned this Oct 10, 2025
@theborakompanioni theborakompanioni added refactoring Code refactoring without functional changes v2 Related to the redesigned v2 release labels Oct 10, 2025
nischal-shetty2
nischal-shetty2 approved these changes Oct 10, 2025
View reviewed changes
Copy link
Contributor

@nischal-shetty2 nischal-shetty2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theborakompanioni theborakompanioni marked this pull request as ready for review October 10, 2025 18:58
@theborakompanioni theborakompanioni merged commit 7c8529f into v2 Oct 11, 2025
3 checks passed
@theborakompanioni theborakompanioni deleted the tbk/refactor branch October 11, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nischal-shetty2 nischal-shetty2 nischal-shetty2 approved these changes

Assignees

@theborakompanioni theborakompanioni

Labels

refactoring Code refactoring without functional changes v2 Related to the redesigned v2 release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@theborakompanioni @nischal-shetty2