Fix/french license plate format #2252
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added new DOI provider with correct implementation - Removed incorrect DOI implementation from Spanish locale - Added tests for DOI provider - Updated CHANGELOG.md
- Added Brazilian ISBN provider with group code 85
- Ensured Faker('pt_BR') generating ISBNs with Brazilian group prefix
- Added tests to verify Brazilian ISBN generation
- Fixed the issue where pt_BR locale ignored locale and generated international ISBNs
- Updated documentation to clarify new format (AA-999-AA) since 2009 - Added specific methods for new and old format license plates - Added comprehensive tests for both formats - New format is properly prioritized
fcurella
requested changes
Aug 26, 2025
fcurella
requested changes
Sep 15, 2025
Collaborator
|
I see unrelated changes to the ISBN portogues provider. Could you clean up your branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
This PR updates French license plate format that has been in use since 2009.
Changes are:
What was wrong
French license plate format implementation was using an outdated format. France switched to a new format in 2009. The current format should be AA-999-AA instead of the old 999-AAA-99 format.
How this fixes it
Changes now correctly reflects the current French license plate system.
Documentation: Added comments explaining that the new format AA-999-AA has been in use since 2009, with the old format kept for historical compatibility.
Added Specific Methods:
Added tests to ensure both formats generate correctly and follow the proper patterns.
The default license_plate() method continues to work and prioritizes the new format.
Test Results: All 85 automotive tests pass, including the new French license plate format tests.
Fixes #2247
Checklist
make lint