Nl nl ssn issue #2253 #2254
Open
Nl nl ssn issue #2253 #2254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcurella
requested changes
Aug 26, 2025
Collaborator
fcurella
left a comment
fcurella
left a comment
There was a problem hiding this comment.
can you add a unit test for regression purposes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Fix issue #2253 on
ssn()in 'nl_NL' provider.What was wrong
Generated
ssn()values had unique leading 8 digits, which is not a BSN (Dutch ssn) requirement.As a consequence the range (number of possible values) was limited to 10! / 2! * 9 / 10.
How this fixes it
Replace
random.sample()byrandom.choices()andcontinuein casedigits[:2] == [0, 0]inssn()code.Now the range is 10 ** 8 * 99 / 100 * 9 / 10, and I generated 20 million unique BSN's without issue (other than 2.6 million collisions).
Checklist
make lint(I didn't install locally)