feat(pt_BR): Improve internet provider data and logic #2304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add modern free email domains (outlook, icloud, etc) - Fix TLD formats (remove leading dots) - Improve username generation handling accented characters (ã, õ, á, etc) - Update and expand tests for pt_BR internet provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Reason
The current
pt_BR(Portuguese - Brazil) internet provider data is outdated. It lacks common modern email providers, has some inconsistencies in TLD formatting, and the username generation logic could better handle specific Portuguese accented characters for more realistic slugs.Changes
Provider Implementation (
faker/providers/internet/pt_BR/__init__.py):outlook.com.br,outlook.com,icloud.com, andyahoo.com.brto reflect current usage in Brazil.com.brdo not have leading dots to avoid double-dot issues in generated URLs.ã,õ,ç,á) into ASCII for usernames and slugs (e.g.,João->joao).Testing (
tests/providers/test_internet.py):TestPtBr: Replaced the basic test class with a comprehensive one.