Add major Swiss banks to de_CH bank provider#2337
Merged
fcurella merged 1 commit intojoke2k:masterfrom Mar 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change
Added a tuple of 12 major Swiss banks to the de_CH bank provider. Containing major banks as listed by Wikipedia
What was wrong
Calling
Faker("de_CH").bank()raised anAttributeErrorbecause Faker is missing that specific dataset for the given locale.How this fixes it
Added the missing tuple to the
de_CHlocale so Faker can provide a bank name when running inde_CHlocale.Also added an additional test to check for the new tuple of banks.
Checklist
make lint