Skip to content

fix(en_IE): generate structurally valid Irish IBANs #2411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CedricConday wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

fix(en_IE): generate structurally valid Irish IBANs #2411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion faker/providers/bank/en_IE/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
class Provider(BankProvider):
"""Implement bank provider for ``en_IE`` locale."""

bban_format = "#######################"
bban_format = "????##############"
country_code = "IE"
4 changes: 2 additions & 2 deletions tests/providers/test_bank.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,14 +174,14 @@ class TestEnIe:

def test_bban(self, faker, num_samples):
for _ in range(num_samples):
assert re.fullmatch(r"\d{23}", faker.bban())
assert re.fullmatch(r"[A-Z]{4}\d{14}", faker.bban())

def test_iban(self, faker, num_samples):
for _ in range(num_samples):
iban = faker.iban()
assert is_valid_iban(iban)
assert iban[:2] == EnIeBankProvider.country_code
assert re.fullmatch(r"\d{2}\d{23}", iban[2:])
assert re.fullmatch(r"\d{2}[A-Z]{4}\d{14}", iban[2:])


class TestEnIn:
Expand Down