fix(vi_VN): update address formats, administrative units, and postcodes - #2433
Open
hmtrii wants to merge 3 commits into
Open
fix(vi_VN): update address formats, administrative units, and postcodes#2433hmtrii wants to merge 3 commits into
hmtrii wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change
Updates the
vi_VNaddress provider to generate more realistic and current Vietnamese addresses.The changes include:
What was wrong
The provider contained outdated administrative-unit data, generated six-digit postcodes, and supported only limited Vietnamese address formats.
How this fixes it
The provider now uses the current administrative structure and postcode ranges while composing addresses from realistic Vietnamese address components.
Fixes #2432
AI Assistance Disclosure (REQUIRED)
AI assistance was used to help review the changes and draft the issue and pull request descriptions.
Checklist
make lint