Skip to content

Add activerecord-51 gemfile #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ALacker
Copy link

@ALacker ALacker commented Jun 7, 2017

Allow activemodel-associations to work with rails 5.1.1, specifically the new add_constraints:

https://github.com/rails/rails/blob/5d9d6a4fbf72029266bfa643929a9a80f9286fbe/activerecord/lib/active_record/associations/association_scope.rb#L123

Solves #13

@coveralls
Copy link

coveralls commented Jun 7, 2017

Coverage Status

Coverage decreased (-1.8%) to 91.346% when pulling 264115a on ALacker:update-51 into 8bbea47 on joker1007:master.

@coveralls
Copy link

coveralls commented Jun 8, 2017

Coverage Status

Coverage decreased (-5.6%) to 87.5% when pulling c07095c on ALacker:update-51 into 8bbea47 on joker1007:master.

@joker1007
Copy link
Owner

Thanks!!
But almost spec is failed.
Would you fix migration error and AR-51 spec failure?

@ALacker
Copy link
Author

ALacker commented Jun 9, 2017

On it, annoyingly the tests are now working when running individually, but failing (sometimes) in group. I first blamed http://edgeguides.rubyonrails.org/5_1_release_notes.html#transactional-tests-with-multiple-connections but disabling transactional tests doesn't help

@coveralls
Copy link

coveralls commented Jun 9, 2017

Coverage Status

Coverage increased (+1.3%) to 94.393% when pulling 8dab104 on ALacker:update-51 into 8bbea47 on joker1007:master.

@jeznag
Copy link

jeznag commented Oct 17, 2017

Any updates @ALacker ?

@TrishaPatel
Copy link

I am getting an wrong number of arguments error in activemodel-association.
Can anyone help me?

@CodingAnarchy
Copy link

It looks like this was never merged and ActiveRecord changed again for Rails 5.2, which breaks even this attempted fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants