Skip to content

Add source argument to Handler for compatibility with Rails 6+ - #11

Open
mrpinsky wants to merge 1 commit into
joliss:masterfrom
mrpinsky:rails-6
Open

Add source argument to Handler for compatibility with Rails 6+#11
mrpinsky wants to merge 1 commit into
joliss:masterfrom
mrpinsky:rails-6

Conversation

@mrpinsky

@mrpinsky mrpinsky commented Aug 3, 2020

Copy link
Copy Markdown

Rails 6 now has a deprecation warning that single-arity templates will not be supported in the future. The separate, additional argument is the source of the template so that template compilers can treat the template object's source as immutable.

cf. rails/rails#35119

@mrpinsky

mrpinsky commented Aug 5, 2020

Copy link
Copy Markdown
Author

@joliss Does this look okay to you?

@mrpinsky

Copy link
Copy Markdown
Author

Bump @joliss

@armiiller

Copy link
Copy Markdown

Anything on this @joliss ? I've started installing this gem via @mrpinsky 's repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants