Skip to content

Add missing include introduced due to new KConfig item#261

Merged
BrianPugh merged 1 commit into
joltwallet:masterfrom
atanisoft:master
May 22, 2026
Merged

Add missing include introduced due to new KConfig item#261
BrianPugh merged 1 commit into
joltwallet:masterfrom
atanisoft:master

Conversation

@atanisoft

Copy link
Copy Markdown
Contributor

Unfortunately, the latest version (1.22.0) has a failure that is reported during builds:

In file included from .../managed_components/joltwallet__littlefs/src/littlefs/lfs_util.h:21,
                 from .../managed_components/joltwallet__littlefs/src/littlefs/lfs.h:11,
                 from .../managed_components/joltwallet__littlefs/src/esp_littlefs.c:12:
.../managed_components/joltwallet__littlefs/src/lfs_config.h: In function 'lfs_malloc':
.../managed_components/joltwallet__littlefs/src/lfs_config.h:223:12: error: implicit declaration of function 'heap_caps_malloc_prefer' [-Wimplicit-function-declaration]
  223 |     return heap_caps_malloc_prefer(size, 2, MALLOC_CAP_8BIT | MALLOC_CAP_SPIRAM, MALLOC_CAP_8BIT | MALLOC_CAP_DEFAULT);
      |            ^~~~~~~~~~~~~~~~~~~~~~~
.../managed_components/joltwallet__littlefs/src/lfs_config.h:223:45: error: 'MALLOC_CAP_8BIT' undeclared (first use in this function)
  223 |     return heap_caps_malloc_prefer(size, 2, MALLOC_CAP_8BIT | MALLOC_CAP_SPIRAM, MALLOC_CAP_8BIT | MALLOC_CAP_DEFAULT);
      |                                             ^~~~~~~~~~~~~~~
.../managed_components/joltwallet__littlefs/src/lfs_config.h:223:45: note: each undeclared identifier is reported only once for each function it appears in
.../managed_components/joltwallet__littlefs/src/lfs_config.h:223:63: error: 'MALLOC_CAP_SPIRAM' undeclared (first use in this function)
  223 |     return heap_caps_malloc_prefer(size, 2, MALLOC_CAP_8BIT | MALLOC_CAP_SPIRAM, MALLOC_CAP_8BIT | MALLOC_CAP_DEFAULT);
      |                                                               ^~~~~~~~~~~~~~~~~
.../managed_components/joltwallet__littlefs/src/lfs_config.h:223:100: error: 'MALLOC_CAP_DEFAULT' undeclared (first use in this function)
  223 |     return heap_caps_malloc_prefer(size, 2, MALLOC_CAP_8BIT | MALLOC_CAP_SPIRAM, MALLOC_CAP_8BIT | MALLOC_CAP_DEFAULT);
      |                                                                                                    ^~~~~~~~~~~~~~~~~~

This resolves the inclusion based on the new KConfig define.

Add missing define for new KConfig entry to include esp_heap_caps.h
@BrianPugh BrianPugh merged commit 6a762cc into joltwallet:master May 22, 2026
12 checks passed
@BrianPugh

Copy link
Copy Markdown
Member

thanks! released in v1.22.1 (currently being built in CI)

@atanisoft

Copy link
Copy Markdown
Contributor Author

Thanks, I just happened upon it as part of testing this morning. Once 1.22.1 is out I'll switch it back over from SPIRAM only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants