Skip to content

public-key: Fix equals to actually work #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2025
Merged

public-key: Fix equals to actually work #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.zig.zon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.{
.fingerprint = 0xdc47aff950fd68c0,
.name = .solana_program_sdk,
.version = "0.16.1",
.version = "0.16.2",
.minimum_zig_version = "0.14.0",

// This field is optional.
Expand Down
9 changes: 8 additions & 1 deletion src/public_key.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ pub const PublicKey = extern struct {
}

pub fn equals(self: PublicKey, other: PublicKey) bool {
return self.bytes == other.bytes;
return std.mem.eql(u8, &self.bytes, &other.bytes);
}

pub fn isPointOnCurve(self: PublicKey) bool {
Expand Down Expand Up @@ -238,3 +238,10 @@ test "public_key: comptime find program address" {
try testing.expectFmt("2PjSSVURwJV4o9wz1BDVwwddvcUCuF1NKFpcQBF9emYJ", "{}", .{pda.address});
try comptime testing.expectEqual(@as(u8, 255), pda.bump_seed[0]);
}

test "public_key: equality" {
const id = comptime PublicKey.comptimeFromBase58("11111111111111111111111111111111");
const id2 = comptime PublicKey.comptimeFromBase58("11111111111111111111111111111111");
try testing.expectEqual(id, id2);
try testing.expect(id.equals(id2));
}
Loading