Skip to content

Conversation

@jondo2010
Copy link
Owner

Improve safety documentation and update lifetime annotations for ReactorBuilderState and ReactionBuilderState. Simplify the pinning logic in the store for better clarity and safety.

@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 98.30508% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.97%. Comparing base (7030d27) to head (f8f1e77).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   76.98%   76.97%   -0.02%     
==========================================
  Files          49       49              
  Lines        7392     7388       -4     
==========================================
- Hits         5691     5687       -4     
  Misses       1701     1701              
Components Coverage Δ
boomerang 100.00% <ø> (ø)
boomerang_builder 70.26% <75.00%> (ø)
boomerang_derive 89.06% <ø> (ø)
boomerang_runtime 77.59% <100.00%> (-0.04%) ⬇️
boomerang_tinymap 90.71% <100.00%> (ø)
boomerang_util 23.68% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jondo2010 jondo2010 requested a review from Copilot October 6, 2025 12:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves safety documentation and updates lifetime annotations for builder states while simplifying the pinning logic in the store. The changes focus on making the pinning mechanism more explicit and safe while updating lifetime annotations to be more precise.

  • Updated lifetime annotations for ReactorBuilderState and ReactionBuilderState to be more explicit
  • Replaced manual PhantomPinned approach with pin-project crate for safer pinning
  • Enhanced safety documentation for iter_borrow_storage method with detailed requirements

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
boomerang_tinymap/src/secondary_map/mod.rs Added explicit lifetime annotation to values() method return type
boomerang_runtime/src/store.rs Major refactoring to use pin-project instead of manual pinning, enhanced safety documentation
boomerang_runtime/src/refs.rs Simplified trait bound syntax by removing unnecessary parentheses
boomerang_runtime/src/port/mod.rs Simplified trait bound syntax by removing unnecessary parentheses
boomerang_runtime/Cargo.toml Added pin-project dependency for safer pinning
boomerang_builder/src/reactor.rs Added explicit lifetime annotation to add_reaction return type
boomerang_builder/src/fqn.rs Fixed import organization by moving runtime import to test module
boomerang_builder/src/env/mod.rs Added explicit lifetime annotations to builder method return types

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jondo2010 jondo2010 merged commit 231d4c1 into main Oct 6, 2025
16 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant