feat: convention-first asset resolution with IAssetCatalog#122
Merged
Conversation
…nd SharedStylesheet
…e generators Introduce IAssetCatalog as a new service layer above IAssetResolver. The catalog resolves logical asset requests into concrete paths; the resolver handles loading. DefaultAssetCatalog is a pass-through that preserves current behavior. Source generators now emit catalog calls instead of literal path strings. Both layout and stylesheet generators pass the declaring type and computed path to the catalog, enabling future catalog implementations to override resolution without changing generators. Add AssetRootAttribute as the successor to AssetPrefixAttribute. AssetRoot takes priority when both are present. AssetPrefix is marked [Obsolete] and will be removed in a future version.
…ation Add AssetRegistryAugmentGenerator, a new Roslyn source generator that produces a static UIComponentAssetRegistry class mapping all non-abstract UIComponent types to their resolved asset paths (layout + stylesheets). Private and protected nested types are excluded from the registry. Add ConventionValidator editor utility with a menu item (UIComponents > Validate Convention Assets) that queries the registry via reflection and checks whether assets exist on disk.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
===========================================
- Coverage 100.00% 94.58% -5.42%
===========================================
Files 57 60 +3
Lines 1771 2068 +297
Branches 235 288 +53
===========================================
+ Hits 1771 1956 +185
- Misses 0 95 +95
- Partials 0 17 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Layout]and[Stylesheet]for convention-based resolution(class name as asset path,
.stylesuffix for stylesheets)[SharedStylesheet("name")]for explicit shared stylesheet loadingIAssetCatalogas a resolution layer aboveIAssetResolver(catalog resolves logical requests to paths, resolver loads)
AssetRootAttributeto replaceAssetPrefixAttribute(deprecated)UIComponentAssetRegistrymapping component types to asset paths