Skip to content

feat: replace IAssetResolver + IAssetCatalog with IAssetSource#123

Merged
jonisavo merged 1 commit into
mainfrom
feat/asset-sources
Mar 15, 2026
Merged

feat: replace IAssetResolver + IAssetCatalog with IAssetSource#123
jonisavo merged 1 commit into
mainfrom
feat/asset-sources

Conversation

@jonisavo

Copy link
Copy Markdown
Owner

Combine the separate catalog (path resolution) and resolver (asset loading) interfaces into a single IAssetSource interface. Convention resolution moves inside source implementations.

  • Add IAssetSource interface (same methods as IAssetResolver)
  • Add ResourcesAssetSource (default), AssetDatabaseAssetSource (editor with convention resolution via FindAssets), AddressableAssetSource
  • Update generators to emit AssetSource.LoadAsset(path) directly
  • Remove IAssetCatalog and DefaultAssetCatalog
  • Deprecate IAssetResolver (extends IAssetSource for backward compat)
  • UIComponent falls back to IAssetResolver if configured, for migration

Combine the separate catalog (path resolution) and resolver (asset
loading) interfaces into a single IAssetSource interface. Convention
resolution moves inside source implementations.

- Add IAssetSource interface (same methods as IAssetResolver)
- Add ResourcesAssetSource (default), AssetDatabaseAssetSource (editor
  with convention resolution via FindAssets), AddressableAssetSource
- Update generators to emit AssetSource.LoadAsset<T>(path) directly
- Remove IAssetCatalog and DefaultAssetCatalog
- Deprecate IAssetResolver (extends IAssetSource for backward compat)
- UIComponent falls back to IAssetResolver if configured, for migration
@jonisavo jonisavo added the enhancement New feature or request label Mar 15, 2026
@codecov

codecov Bot commented Mar 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.83721% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.59%. Comparing base (f633b5c) to head (39981c6).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ts/UIComponents/Editor/AssetDatabaseAssetSource.cs 97.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   94.58%   92.59%   -1.99%     
==========================================
  Files          60       62       +2     
  Lines        2068     2135      +67     
  Branches      288      287       -1     
==========================================
+ Hits         1956     1977      +21     
- Misses         95      141      +46     
  Partials       17       17              
Flag Coverage Δ
automated 92.59% <98.83%> (-1.99%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jonisavo
jonisavo merged commit e30a556 into main Mar 15, 2026
10 of 11 checks passed
@jonisavo
jonisavo deleted the feat/asset-sources branch March 15, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant