feat: replace IAssetResolver + IAssetCatalog with IAssetSource#123
Merged
Conversation
Combine the separate catalog (path resolution) and resolver (asset loading) interfaces into a single IAssetSource interface. Convention resolution moves inside source implementations. - Add IAssetSource interface (same methods as IAssetResolver) - Add ResourcesAssetSource (default), AssetDatabaseAssetSource (editor with convention resolution via FindAssets), AddressableAssetSource - Update generators to emit AssetSource.LoadAsset<T>(path) directly - Remove IAssetCatalog and DefaultAssetCatalog - Deprecate IAssetResolver (extends IAssetSource for backward compat) - UIComponent falls back to IAssetResolver if configured, for migration
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
==========================================
- Coverage 94.58% 92.59% -1.99%
==========================================
Files 60 62 +2
Lines 2068 2135 +67
Branches 288 287 -1
==========================================
+ Hits 1956 1977 +21
- Misses 95 141 +46
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combine the separate catalog (path resolution) and resolver (asset loading) interfaces into a single IAssetSource interface. Convention resolution moves inside source implementations.