Support ocaml 5.2 #10
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuihtlauac
commented
Mar 21, 2025
cuihtlauac
commented
- Replace Firebug by Console
- Try support OCaml 5.2
added 2 commits
March 21, 2025 15:22
Compilation fails with:
```
File "lib/uTop.ml", line 284, characters 18-26:
Error: Unbound value Exp.fun_
```
Because `fun_` was removed by commit 739f574cd1bbda3489809e25949c4cd1c262d407
It is unclear what to do with block from lines 280-294
Additionally, in file `lib/worker.cppo.ml`, lines 218-220, this was added:
```
visibility = Visible
```
Although it compiles, it is unclear if it is the right thing to do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.