Chore: Updates and Cleanup

[hashworks]

I just released v1.6.1 to the Arch Linux extra repo. But it would be great if you could release a v1.7.0 with the latest go & dep versions.

Closes #88.

[hashworks]

Supersedes #85

[hashworks]

Tested with latest 7.5.0, works fine.

[hashworks]

@jonnenauha would you like me to adjust anything here?

[steinbrueckri]

bump 🎉

[jonnenauha]

Why would go 1.22 be required? I get the version bump if deps require it, but im not using packages that need new APIs from later go releases.

Prom seems to require go 1.21 so we should target that. https://github.com/prometheus/client_golang/blob/main/go.mod#L3

Despite what the go.mod says here, whatever go version you have will be used to build the binary. Its not like if you have go 1.23 installed and build it, it's not going to be be like you built it with go 1.12. go mod tells you the minimum version you can use to build the code. So if you are using features released in later go versions you can enforce it here.

But I agree bumping the version up to 1.21 is sensible. It can probably enable some compiler features versus 1.12.

[jonnenauha]

One more note, the travis ci go version update is ofc importatnt as it pushes the offiicial releases to github. So that is great, I was more talking about the go.mod changes here.

[hashworks]

That's just me bumping everything to latest, you are correct, we can set this to 1.21.

[hashworks]

EDIT: Actually, since 1.23 has been released this is no longer correct. I wouldn't set 1.21 here since it is no longer supported:

Each major Go release is supported until there are two newer major releases.

[hashworks]

@jonnenauha Do you still want to support 1.21 even trough go itself does not support it any longer?

[jonnenauha]

what auto formatter are you using to remove the struct name here? i have never seen the official go fmt do this? I think this is an unnecessary change.

[hashworks]

This is the result of gofmt -s, it "simplifies" code. Defining the struct type here is redundant.

[jonnenauha]

this certainly is not go fmt either right?

[hashworks]

That's just standard go fmt.

$ git status
On branch master
Your branch is up to date with 'origin/master'.
$ go fmt ./prometheus.go
$ git diff
  diff --git a/prometheus.go b/prometheus.go
  index c54f642..533051e 100644
  --- a/prometheus.go
  +++ b/prometheus.go
  @@ -229,7 +229,7 @@ func cleanBackendName(name string) string {
      if strings.HasPrefix(name, "reload_") {
          dot := strings.Index(name, ".")
          if dot != -1 {
  -           name = name[dot + 1:]
  +           name = name[dot+1:]
          }
      }

[jonnenauha]

so did you actually change any logic here or just run it through some auto formatter? i dont see the point, afaik the script was working fine.

[hashworks]

Neither. Yes, /bin/bash will work fine on most systems, but in rare cases this path is not correct (NixOS comes to mind). /bin/env bash ensures it works across the board. It's just good practice.

[Sakoes]

Pro merging and releasing this for minimizing security vulnerabilities. Love this pluging

[steinbrueckri]

@hashworks It looks like this will not merged for unknown reason, do you maintain your own fork?

[hashworks]

No, sorry.

[Sakoes]

Would be disappointing to not get this merged. @jonnenauha anything you need before being able to merge this? Would love to help if there are any issues