feat(bench): add oneTypeof, oneLiner and twoLiner tests#7
Open
pi0 wants to merge 2 commits into
Open
Conversation
Author
|
Node 0.x is failing because of usage of |
Owner
I don't feel strongly either way, but I think it's okay if we drop support for Node.js 0.x. Thoughts? Thanks for doing this! |
Author
|
@jonschlinkert Friendly reminder about this PR :D |
Owner
|
Can't believe I forgot about this PR for so long. Sorry @pi0! Before I merge, did you want to update the main export to use the function that was fastest in benchmarks? The current function did pretty well, so I'm fine with either way. |
Author
|
NP @jonschlinkert. Sure will update branch 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I've added 3 new variants to the benchmarks:
oneTypeof,oneLinerandtwoLiner.Results
All tests was runned on MacBook Pro / 10.14. It seems that
twoLineris the winner in all runs.Node 8
Run 1:
Run 2:
Node 10
Run 1:
Run 2: