This repository was archived by the owner on Nov 28, 2017. It is now read-only.
Rename en-GB.en-GB.plg_system_jefreg.ini to en-GB.plg_system_jefreg.ini#2
Open
mgilkes wants to merge 11 commits into
Open
Rename en-GB.en-GB.plg_system_jefreg.ini to en-GB.plg_system_jefreg.ini#2mgilkes wants to merge 11 commits into
mgilkes wants to merge 11 commits into
Conversation
- fixed the regex to clean the commercial file. It was not cleaning the spaces properly. - fixed the regex that detects the commcerial file. Removed the colon in the expression. The expression is supposed to detect *[appid]=>[link], not *:[appid]=>[link]
You must set the field as required. If the field is not required when $jefreg['installat'] is empty, the rule test for the field will return as true (i.e. valid).
You must set the field as required. If the field is not required when $jefreg['installat'] is empty, the rule test for the field will return as true (i.e. valid).
Removed the extra "en-GB.". It only needs one. So, the file should be "en-GB.plg_system_jefreg.ini", not "en-GB.en-GB.plg_system_jefreg.ini"
The sessid GET variable was base64 encoded. It should not be. It will never be detected if it is.
Update jefreg.php
You must set the field as required. If the field is not required when $jefreg['installat'] is empty, the rule test for the field will return as true (i.e. valid), instead of false.
Just merging the patches with the master, although I made this change already in the master. :)
|
Thanks for pointing the en-GB problem. I'll merge as soon as I test the rest of the changes. Thanks! |
Changed back to include sessid in the base64 encode for $installfrom, based on clarification from emavro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the extra "en-GB.". It only needs one. So, the file should be "en-GB.plg_system_jefreg.ini", not "en-GB.en-GB.plg_system_jefreg.ini"