Skip to content

Fixes 1593. https://github.com/joomla/joomla-cms/issues/1593 #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixes 1593. https://github.com/joomla/joomla-cms/issues/1593 #1609

wants to merge 1 commit into from

Conversation

aheinze
Copy link

@aheinze aheinze commented Jul 29, 2013

added possibility to mark select boxes which should not be touched by chosen.

@Hackwar
Copy link
Member

Hackwar commented Mar 2, 2014

Why are you adding this only to those 2 layouts and not all layouts?

Can you create a tracker item on Joomlacode for this?

@Bakual
Copy link
Contributor

Bakual commented Mar 2, 2014

Actually, I would prefer an opt-in solution like was planned initially. If you look at the function you see that the default selector would be advancedSelect. But developers got lazy and just applied it to every select instead, breaking modules and templates and whatnot left and right. Doesn't matter if it's output from their component, it's applied to every select on the whole page.

That is the real issue. Changing the selector to something which allows to opt-out is only a workaround imho.

@Hackwar
Copy link
Member

Hackwar commented Mar 2, 2014

I agree, but since that is not backwards compatible, we unfortunately have to wait for 4.0. sigh We should keep a log of which snafus we want to fix in 4.0...

@Bakual
Copy link
Contributor

Bakual commented Mar 2, 2014

Imho we could do it mostly backward compatible for some views at least. I think I still have a PR somewhere with an idea for that and there are also some other PRs dealing with the same.
Also, it's not like something really breaks if chosen is not loaded.

@betweenbrain
Copy link
Contributor

@Bakual is this the issue? #2018

@Bakual
Copy link
Contributor

Bakual commented Mar 3, 2014

@betweenbrain Same issue, different idea to solve it, yes.
My own PR would be #1620 where the idea mainly is adding a default class to the list formfield so we don't have to edit 100+ XML files 😄

@brianteeman
Copy link
Contributor

closing in favour of #3721

@brianteeman brianteeman closed this Aug 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants