Skip to content

Comments

[6.0] Reduce exclusions in phpstan-baseline.neon#46858

Merged
Bodge-IT merged 3 commits intojoomla:6.0-devfrom
richard67:6.0-dev-update-phpstan-baseline-2026-02-08
Feb 18, 2026
Merged

[6.0] Reduce exclusions in phpstan-baseline.neon#46858
Bodge-IT merged 3 commits intojoomla:6.0-devfrom
richard67:6.0-dev-update-phpstan-baseline-2026-02-08

Conversation

@richard67
Copy link
Member

@richard67 richard67 commented Feb 8, 2026

Pull Request for Issue # .

Summary of Changes

This pull request (PR) adapts the phpstan-baseline.neon to recent fixes in the code base so that the number of some exclusions are reduced.

By reducing the numbers we make sure that no new PHPstan errors of this kind will be added to the same files by mistake with some new code.

@Bodge-IT @softforge It is the same as PR #46857 for 5.4-dev, but here for 6.0-dev, in order to avoid a merge conflict later when the 5.4-dev PR will be merged up into 6.0-dev. When this PR will be merged before that upmerge, you simply can resolve the conflict by choosing to keep the file from 6.0-dev.

Testing Instructions

  1. Code review: Check that this PR does not add any new stuff, it only reduces the number of exclusions at 2 places.
  2. Check that the GitHub action for the PHPstan check succeeds.

Actual result BEFORE applying this Pull Request

PHPstan succeeds, but the number of occurrences for 2 exclusions is larger than necessary.

Expected result AFTER applying this Pull Request

PHPstan succeeds, and the number of occurrences for 2 exclusions has been reduced.

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Copy link
Contributor

@muhme muhme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Same change as in #46857 for 5.4-dev
  • Only numbers are changed
  • GitHub action phpstan is successful
  • libraries/vendor/bin/phpstan analyse --generate-baseline and see exactly the same changes

@Bodge-IT Bodge-IT merged commit 0e155ea into joomla:6.0-dev Feb 18, 2026
51 checks passed
@Bodge-IT
Copy link
Contributor

Thank you 5.4 team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants